feat/CXSPA-7935:Modify the OCC API endpoint for SPA consumes(#19141) #19141
+38
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clordc
changed the title
clordc
changed the title
added 2 commits
August 19, 2024 14:23
scarai-sap
reviewed
Aug 19, 2024
| @@ -11,7 +11,7 @@ export const defaultOccUserProfileConfig: OccConfig = { | |||
| occ: { | |||
| endpoints: { | |||
| userRegister: 'users', | |||
| userForgotPassword: 'forgottenpasswordtokens', | |||
| userForgotPassword: 'passwordRestoreToken', | |||
There was a problem hiding this comment.
create new one instead of change existing one.
| ...CONTENT_TYPE_URLENCODED_HEADER, | ||
| }); | ||
| const body = { loginId: userEmailAddress }; | ||
| let headers = new HttpHeaders(CONTENT_TYPE_JSON_HEADER); |
There was a problem hiding this comment.
Suggested change
| let headers = new HttpHeaders(CONTENT_TYPE_JSON_HEADER); | |
| const headers = new HttpHeaders(CONTENT_TYPE_JSON_HEADER); |
|
Test summaryRun details
Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud |
||||||||||||||||||||||||||||||||||||||||||||||||||
i336588
reviewed
Aug 19, 2024
|
|
||
| expect(mockReq.request.body).toEqual({ | ||
| newLoginId: newUserId, | ||
| password: currentPassword, |
There was a problem hiding this comment.
Suggested change
| password: currentPassword, | |
| password: currentPassword |
| @@ -351,8 +341,11 @@ describe('OccUserProfileAdapter', () => { | |||
| ); | |||
|
|
|||
| expect(mockReq.cancelled).toBeFalsy(); | |||
| expect(mockReq.request.body).toEqual({ | |||
| oldPassword: oldPassword, | |||
| newPassword: newPassword, | |||
There was a problem hiding this comment.
Suggested change
| newPassword: newPassword, | |
| newPassword: newPassword |
| return this.http.put(url, httpParams, { headers }).pipe( | ||
| const body = { | ||
| oldPassword: oldPassword, | ||
| newPassword: newPassword, |
There was a problem hiding this comment.
Suggested change
| newPassword: newPassword, | |
| newPassword: newPassword |
| return this.http.put(url, httpParams, { headers }).pipe( | ||
| const body = { | ||
| newLoginId: newUserId, | ||
| password: currentPassword, |
There was a problem hiding this comment.
Suggested change
| password: currentPassword, | |
| password: currentPassword |
scarai-sap
approved these changes
Aug 20, 2024
pawelfras
added a commit
that referenced
this pull request
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The below old OCC API endpoints are deprecated:
https://api.cg79x9wuu9-eccommerc1-p1-public.model-t.myhybris.cloud/occ/v2/swagger-ui/index.html#/Users/replaceUserLogin
https://api.cg79x9wuu9-eccommerc1-p1-public.model-t.myhybris.cloud/occ/v2/swagger-ui/index.html#/Users/replaceUserPassword
https://api.cg79x9wuu9-eccommerc1-p1-public.model-t.myhybris.cloud/occ/v2/swagger-ui/index.html#/Forgotten%20Passwords/doRestorePassword
SPA should be consume the below new OCC API endpoints instead of the deprecated ones:
https://api.cg79x9wuu9-eccommerc1-p1-public.model-t.myhybris.cloud/occ/v2/swagger-ui/index.html#/Users/changeUserLoginId
https://api.cg79x9wuu9-eccommerc1-p1-public.model-t.myhybris.cloud/occ/v2/swagger-ui/index.html#/Users/changeUserPassword
https://api.cg79x9wuu9-eccommerc1-p1-public.model-t.myhybris.cloud/occ/v2/swagger-ui/index.html#/Forgotten%20Passwords/sendPasswordRestoreToken
Regression test needs to be done.